Finance | Project Operations, Human Resources, ...

catch exception x++

(1) Share

Report

Posted on by CU22120935-0

190

Hi,

I know that catch(ex) is good as it catches mostly everything, but in my code here i don't use it
do i need it?
how to make my code better?

 public ResponseContract createCustomer(RequestContract _requestContract)
 {
     int startLine = Global::infologLine();
    ResponseContract  responseContract  = new ResponseContract ();
     System.Exception    ex;

     try
     {
        //logic
     }
     catch(ex)
     {
        int     currentLine;
        str     errorMessage;
        boolean ret = true;

        for (currentLine = _startLine + 1; currentLine <= infologLine(); currentLine++)
        {
            if (ret)
            {
                errorMessage = infolog.text(currentLine);
                ret = false;
            }
            else
            {
               errorMessage += '\n' + infolog.text(currentLine);
            }
        }

         response.parmMessage(errorMessage);
         
     }

     return responseContract;
 }

Categories:

Dynamics 365 Finance

I have the same question (0)

All responses (3)

Answers (0)

Sort by

Suggested answer

Martin Dráb 239,533 Most Valuable Professional on at

Like (1)

Report
Copy link

Link copied!

Whether you need to handle exceptions in a special way or you can just use the default handler depends on your business requirements.

Your code populating errorMessage variable is indeed useless, because the variable isn't used for anything.

But it's not the same as if you didn't use any catch clause at all. Your code is an equivalent of an empty catch clause - it swallows the exception without doing anything with it.

Was this reply helpful? Yes No
Subra 582 on at

Like (1)

Report
Copy link

Link copied!

Hi

Always catch is good to have in your code and keep it with default catch execption. if you don't need it for your business requirements.

Was this reply helpful? Yes No
Martin Dráb 239,533 Most Valuable Professional on at

Like (1)

Report
Copy link

Link copied!

Always catching exceptions is a bad idea. If you aren't interested in handling an exception and you catch it without rethrowing, you've just created a critical bug. The application will continue to run in a fault state instead of throwing an exception, which may have huge consequences.

Even if you rethrow the exception, it's much worse than not catching it at all. The behavior will be the same, but performance will be worse and debugging more complicated.

Was this reply helpful? Yes No