Error in Javascript

(0) Share

Report

Posted on by Community Member

Hi!

Before the user leaves the form (Contact), either closes the form, close the window (web browser) or clicks in the menu I need to save some data to the entity.

My script is called from the OnLoad event of the form and it looks like this:

function SaveBeforeClosingForm() 
{
  window.onbeforeunload = function() 
  {
    Xrm.Page.getAttribute("new_optionalstatus").setValue(100000001);
    Xrm.Page.data.entity.save();
    return null; 
  }
}

It works fine the first time I open the form and closes it. 
When I open it again I can see my change have been saved but when I try to close it the second time I get a Javascript error. 
I don't see anything wrong in my code, it works the first time. 

Any help out there?

*This post is locked for comments

I have the same question (0)

All responses (3)

Answers (0)

Suggested answer

Gopalan Bhuvanesh 11,401 on at

Like (1)

Report

Hi

Using DOM and event handling for the DOM events (Example: window.onbeforeunload) is not supported.

Unsupported customization is not recommended.

Please refer the following:

gustafwesterlund.blogspot.co.uk/.../unsupported-customizations.html

Was this reply helpful? Yes No
Suggested answer

ashlega 34,477 on at

Like (1)

Report

Hi,

I think Gopalan is (just removed "somewhat" here) correct that you should not be using unsupported methods.. On the other hand, window object is always going to be there.. However, dynamics is, probably, already using onbeforeunload. You are overwriting it, so you are breaking out-of-the-box scripts (why it's working the first time and not working the second time I don't know - does not matter that much)

You migth try to do it this way - might help:

var defaultOnBeforeUnload = null;

function SaveBeforeClosingForm()

{

defaultOnBeforeUnload = window.onbeforeunload;

window.onbeforeunload = function()

{

Xrm.Page.getAttribute("new_optionalstatus").setValue(100000001);

Xrm.Page.data.entity.save();

if(defaultOnBeforeUnload != null)

defaultOnBeforeUnload();

return null;

}

}

Was this reply helpful? Yes No
Suggested answer

Guido Preite 54,086 Moderator on at

Like (1)

Report

if your purpose is to set a default value for that optionset, then use a synchronous workflow or a plugin instead doing some javascript

Was this reply helpful? Yes No