I set batch class that extends from runbasebatch but when I used this.isinbatch always return false and I don't know why ??

(0) Share

Report

Posted on by Codehunter

10,280

Please advise as I need to set run ()method to be run only inside the batch but it isn't working and the method this.isinbatch return false always and I don't know why.

I have the same question (0)

All responses (42)

Answers (1)

Sort by

Martin Dráb 239,069 Most Valuable Professional on at

Like (0)

Report
Copy link

Link copied!

That the class can run in batch doesn't mean it's actually executed in batch. How are you running it?

By the way, is this thread about AX 2012 or D365FO?

And why don't you use SysOperation framework instead of RunBase?

Was this reply helpful? Yes No
Codehunter 10,280 on at

Like (0)

Report
Copy link

Link copied!

It is AX 2012 r2 and I created new class that extends from runbasbatch but when I use this.isbatch() in run method , always return false besides I run the class as server not client.

Was this reply helpful? Yes No
Codehunter 10,280 on at

Like (0)

Report
Copy link

Link copied!

I need to get this.isinbatch() true but it keeps returning false in run method() so please anyone stuck with such a case, please advise

Was this reply helpful? Yes No
Martin Dráb 239,069 Most Valuable Professional on at

Like (0)

Report
Copy link

Link copied!

That the class can run in batch doesn't mean it's actually executed in batch. How are you running it?

By the way, I changed the version tag from Microsoft Dynamics AX (current version) to Microsoft Dynamics AX 2012. Please use it next time for questions about AX 2012.

Was this reply helpful? Yes No
Codehunter 10,280 on at

Like (0)

Report
Copy link

Link copied!

here is the code

Class batch extends runbasebatch

{

public void run()

{

try

{

ttsbegin;

if(this.isinbatch) ///always return false ************************

/// whatever the implementation is

ttsCommit;

}

catch(Exception::Error)

{

ttsabort;

}

catch(Exception::Deadlock)

{

retry;

}

}

public void BatchStarted()

{

BatchJob batchJob;

BatchRetries noOfRetriesOnFailure = 2;

BatchHeader header;

Batch batch;

batch _FixedAssetsBatch; // Class extends RunBaseBatch

BatchInfo processBatchInfo;

SysRecurrenceData sysRecurrenceData;

header = BatchHeader::construct();

select forupdate batch

join batchJob

where batchJob.RecId == batch.BatchJobId

&& batch.ClassNumber == classnum(FixedAssetsBatch)

&& batchJob.Status == BatchStatus::Waiting

&& batch.Company == curext();

if(!batch)

{

_FixedAssetsBatch = new FixedAssetsBatch();

processBatchInfo = _FixedAssetsBatch.batchInfo();

processBatchInfo.parmRetriesOnFailure(noOfRetriesOnFailure);

processBatchInfo.parmCaption(_FixedAssetsBatch.name()); // Description Batch Job

processBatchInfo.parmGroupId('FABatch'); // Batch Gorup

processBatchInfo.parmBatchExecute(NoYes::Yes);

header.addTask(_FixedAssetsBatch);

// Set the recurrence data

sysRecurrenceData = SysRecurrence::defaultRecurrence();

sysRecurrenceData= SysRecurrence::setRecurrenceStartDate(sysRecurrenceData,today());

SysRecurrence::setRecurrenceStartDateTime(sysRecurrenceData,DateTimeUtil::addSeconds(DateTimeUtil::utcNow(),30)); // Set range of recurrence

sysRecurrenceData=SysRecurrence::setRecurrenceEndAfter(sysRecurrenceData,1);

// SysRecurrence::setRecurrenceUnit(sysRecurrenceData, SysRecurrenceUnit::); // Set reccurence pattern

header.parmRecurrenceData(sysRecurrenceData);

// Set the batch alert configurations

header.parmAlerts(NoYes::No, NoYes::Yes, NoYes::No, NoYes::Yes, NoYes::Yes);

header.save();

}

ttsbegin;

select forupdate batchJob

join batch

where batchJob.RecId == batch.BatchJobId

&& batch.ClassNumber == classnum(FixedAssetsBatch);

sysRecurrenceData = batchJob.RecurrenceData;

sysRecurrenceData = conpoke(sysRecurrenceData, 8, [1]);

batchJob.RecurrenceData = sysRecurrenceData;

batchJob.update();

ttscommit;

}

public static void main(Args _args)

{

batch_FixedAssetsBatch = Batch::construct();

_FixedAssetsBatch.BatchStarted();

_FixedAssetsBatch.init();

// _FixedAssetsBatch.parmBatch(_args);

_FixedAssetsBatch.run();

}

}

Was this reply helpful? Yes No
Martin Dráb 239,069 Most Valuable Professional on at

Like (0)

Report
Copy link

Link copied!
Please always use Insert > Insert Code (in the rich-formatting view) to paste source code. It'll make it much easier to read.

Your code is very strange. You should never do anything like updating BatchJob table directly.

First of all, think about if you don't want to use SysOperation framework rather than RunBaseBatch. You ignored my question on this topic...

If you want to use RunBaseBatch, the first step is implementing the class correctly. Your current code won't even compile, because you forgot to implement pack() and unpack() and the name (Batch) is already taken. (You wouldn't have to implement pack()/unpack() if you used SysOperation.)

Then implement main() like this:

public static void main(Args _args) { MyClass myClass = new MyClass(); if (myClass.prompt()) { myClass.run(); } }

Compile your code and generate CIL.

Then run your class, choose batch processing in the dialog and confirm it.

By the way, what business requirement are you to fulfill by checking if a piece code is running in batch?

Was this reply helpful? Yes No
Codehunter 10,280 on at

Like (0)

Report
Copy link

Link copied!

I set all the pack and unpack methods in the batch but I didn't mention it in the previous post but my problem is that why this.isinbatch() returns false .

Please advise.

Was this reply helpful? Yes No
Suggested answer

Alfasith AX 120 User Group Leader on at

Like (0)

Report
Copy link

Link copied!

Hi,

Correct me if I'm wrong.

If the code runs in batch that means it runs in server if its not in batch then its running in client.

So you can validate using below statement and can proceed.

if (isRunningOnServer())

{

XXXXX

}

else

{

YYYYY

}

Was this reply helpful? Yes No
Suggested answer

nmaenpaa 101,166 Moderator on at

Like (0)

Report
Copy link

Link copied!

Hi Codehunter,

as Martin already mentioned, your code looks very strange and it's almost certainly not the correct solution for your business requirement. I ask you to go back to the drawing board, most likely it will save your time, and also save time and money in the future when this code is maintained.

Was this reply helpful? Yes No
Codehunter 10,280 on at

Like (0)

Report
Copy link

Link copied!

I want to use this.isinbatch() and it always return false besides, I set the class to run on server .

Was this reply helpful? Yes No