Sonar Cube Smell issue for Linq

(0) Share

Report

Posted on by dkrishna

483

Hello,

iam getting error as Drop 'Where' and move the condition into the 'FirstOrDefault' for following linq code in Sonar Cube .. Please suggest how to fix and how can we move Where condition to FirstOrDefault

 Entity docLocation = entityCollection.Entities.Count > 0 ? entityCollection.Entities.Where(s =>
 

            parentLocationRecord.Id == (s.Contains("parentsiteorlocation") ? ((EntityReference)s["parentsiteorlocation"]).Id : Guid.Empty)
 

            && _recordId == (s.Contains("regardingobjectid") ? ((EntityReference)s["regardingobjectid"]).Id : Guid.Empty)).FirstOrDefault() : null;

*This post is locked for comments

I have the same question (0)

All responses (10)

Answers (3)

Suggested answer

RaviKashyap 55,410 Moderator on at

Like (0)

Report

Hi,

You can simply replace Where with FirstOrDefault.

Hope this helps.

Was this reply helpful? Yes No
dkrishna 483 on at

Like (0)

Report

I tried but but getting error at FirstOrDefault in last line.

Entity doesnt contain a defination for FirstOrDefault and No extension method 'FirstOrDefault' accepting first arugment type of Entity

Was this reply helpful? Yes No
RaviKashyap 55,410 Moderator on at

Like (0)

Report

Can you share your code after updating it? I tried it and it seem to work.

Was this reply helpful? Yes No
dkrishna 483 on at

Like (0)

Report
Entity docLocation = entityCollection.Entities.Count > 0 ? entityCollection.Entities.FirstOrDefault(s => parentLocationRecord.Id == (s.Contains("parentsiteorlocation") ? ((EntityReference)s["parentsiteorlocation"]).Id : Guid.Empty) && _recordId == (s.Contains("regardingobjectid") ? ((EntityReference)s["regardingobjectid"]).Id : Guid.Empty)).FirstOrDefault() : null;

Was this reply helpful? Yes No
Verified answer

RaviKashyap 55,410 Moderator on at

Like (0)

Report

Hi,

remove the last FirstOrDefault.

============

Entity docLocation = entityCollection.Entities.Count > 0 ? entityCollection.Entities.FirstOrDefault(s =>

parentLocationRecord.Id == (s.Contains("parentsiteorlocation") ? ((EntityReference)s["parentsiteorlocation"]).Id : Guid.Empty)

&& _recordId == (s.Contains("regardingobjectid") ? ((EntityReference)s["regardingobjectid"]).Id : Guid.Empty)) : null;

============

Hope this helps.

Was this reply helpful? Yes No
dkrishna 483 on at

Like (0)

Report

Thanks alot Ravi ..It works !!

Was this reply helpful? Yes No
dkrishna 483 on at

Like (0)

Report

Its working but does it effects any functionality as iam changing from Where to FirstOrDefault as FirstOrDefault will get first record or default record from list .

Was this reply helpful? Yes No
Verified answer

gdas 50,091 Moderator on at

Like (0)

Report
Hi Krishna,

Try with this -

entityCollection.Entities.Where(s => parentLocationRecord.Id == (s.Contains("parentsiteorlocation") ? ((EntityReference)s["parentsiteorlocation"]).Id : Guid.Empty) && _recordId == (s.Contains("regardingobjectid") ? ((EntityReference)s["regardingobjectid"]).Id : Guid.Empty)).FirstOrDefault();

Was this reply helpful? Yes No
Verified answer

RaviKashyap 55,410 Moderator on at

Like (0)

Report

This will give you same results....with where...you were searching for records and then taking the first or default...with the uodated one you are still retrieving the first or defailt but here you are passing the criteria with firstordefault....this is why you were getting warnings.

Hope this helps

Was this reply helpful? Yes No
dkrishna 483 on at

Like (1)

Report

Thanks Ravi !

Was this reply helpful? Yes No

Community site session details

Sonar Cube Smell issue for Linq

Helpful resources

Quick Links

Responsible AI policies

Neeraj Kumar – Community Spotlight

Congratulations to the November Top 10 Community Leaders!

Leaderboard > 🔒一 Microsoft Dynamics CRM (Archived)

Featured topics

Product updates

Community site session details

Sonar Cube Smell issue for Linq

Helpful resources

Quick Links

Responsible AI policies

Neeraj Kumar – Community Spotlight

Congratulations to the November Top 10 Community Leaders!

Subscribe to this forum!

Select categories

Leaderboard > 🔒一 Microsoft Dynamics CRM (Archived)

Featured topics

Product updates