Small and medium business | Business Central, N...

Update Sales Header total values when inserting a sales line programmatically

(0) Share

Report

Posted on by Nalin.karu

120

Hi All,

I'm doing a customization for Sales Order Card. The requirement is to add a new item line when releasing Sales Order. Adding a new line works fine. following is a code sample used for that.

pageextension 50100 SalesOrderExt extends "Sales Order"
{
    layout
    {

    }
    actions
    {
        modify(Release)
        {
            trigger OnBeforeAction()
            var
                SalesHeader: Record "Sales Header";
                AddPotLevyItem: Codeunit "Add Pot Levy Item";
            begin
                SalesHeader.Copy(Rec);
                AddPotLevyItem.AddItem(SalesHeader);
            end;
        }
    }
}

please note that, Amount of the new item is calculated from existing sales lines values.

    procedure AddItem(SalesHeader: Record "Sales Header")
    var
        SalesLine: Record "Sales Line";
        PotLevyAmount: Decimal;
        NewLineNo: Integer;
        NewSalesLine: Record "Sales Line";
        ItemType: Enum "Sales Line Type";
        ItemNo: Code[20];
    begin
        ItemNo := '1908-S';
        SalesLine.SetRange("Document Type", SalesHeader."Document Type");
        SalesLine.SetRange("Document No.", SalesHeader."No.");
        if SalesLine.FindSet() then begin
            repeat begin
                PotLevyAmount := SalesLine.Amount * (5 / 100);
            end until SalesLine.Next() = 0;

            SalesLine.FindLast();
            NewLineNo := SalesLine."Line No."   10000;

            NewSalesLine.Init();
            NewSalesLine."Document Type" := SalesHeader."Document Type";
            NewSalesLine."Document No." := SalesHeader."No.";
            NewSalesLine."Line No." := NewLineNo;
            NewSalesLine.Validate(Type, ItemType::Item);
            NewSalesLine.Validate("No.", ItemNo);
            if NewSalesLine.Insert(true) then begin
                NewSalesLine.Quantity := 1;
                NewSalesLine.Validate(Quantity);
                NewSalesLine.Amount := PotLevyAmount;
                NewSalesLine.Validate(Amount);
                NewSalesLine.Modify(true);
            end;
        end;
    end;

The issue is that, Sales line total values are not updated.

I highly appreciate your advice.

Thanks,

Nalin.

Categories:

Dynamics 365 Business Central

I have the same question (0)

All responses (8)

Answers (0)

Suggested answer

MahGah 15,529 on at

Like (0)

Report

Hi

I am sure some developer will answer your question.

But I assume since Sales Header total values are "sum flowfield over lines" type they may require some kind of action (such as release) to update them.

Can you in your code first add the line then "release" the SO?

Was this reply helpful? Yes No
Samantha73 3,247 on at

Like (0)

Report

I'm having the same issue has anyone found a solution to when header totals are not getting updated when inserting lines via code?

Was this reply helpful? Yes No
Suggested answer

Akshay_Panchal 402 on at

Like (0)

Report

Hii,

Try to call updateAmount function of sales line after inserting of new sales line.

Thanks.

Verify, If this answer helpful to you.

Was this reply helpful? Yes No
Suggested answer

Chameera Kavinda 510 on at

Like (0)

Report

Try CurrPage.Update at the end of the code

Was this reply helpful? Yes No
CRSW 625 on at

Like (0)

Report

Hi

Any solutions on that? Tried UpdateAmount AND currPage.Update without success

Was this reply helpful? Yes No
Suggested answer

Prtham 171 on at

Like (0)

Report

I think you are validating incorrectly.

if NewSalesLine.Insert(true) then begin

NewSalesLine.Validate(Quantity, 1);

NewSalesLine.Validate(Amount, PotLevyAmount);

NewSalesLine.Modify(true);

end;

Also, at the end of the code, don't forget to get the sales header

IF Rec.Get(Rec.DocumentType, Rec.Document No.) THEN;

Was this reply helpful? Yes No
Suggested answer

Amit 2,557 on at

Like (0)

Report

Hi,

Use this property in sub-form page or you also achieve this requirement by using Flowfields feature. But below property is mandatory.

UpdatePropagation = Both;

Regards

Amit Sharma

www.erpconsultors.com

Press Yes if Info is useful

Was this reply helpful? Yes No
Suggested answer

DAnny3211 11,397 on at

Like (0)

Report

CIao
try inserting a currpage.Update at the end of your code

although honestly I would link more to the codeunit 414 'Release Sales Document' event:

keep in mind that the totals on the order card should be calculated functions

DAniele

Was this reply helpful? Yes No