Add my logic in extension before the standard method call in X++

(0) Share

Report

Posted on by HARISH MEHRA

113

Hi Experts,

I want to write a logic in MAP- InventInventoryJournalEntryMap in method -createJournalHeader with following condition.

1- If the JournalType = Movement and “Original journal No.” field has value.

2- If the existing Journal is “blocked” by system or any user.

If any of these two conditions are true than only the standard method will create a new journal.

For this I have written a code but not working.

Can anyone tell how can I achieve this

[ExtensionOf(mapstr(InventInventoryJournalEntryMap))]
public final class CreateInventoryMomentJournal_CAP_Extension
{
    public static InventJournalTable createJournalHeader(JournalNameId _journalNameId, InventJournalType _expectedJournalType)
    {
        InventJournalTable inventJournalTable;


        inventJournalTable = next createJournalHeader(_journalNameId, _expectedJournalType);

        if (inventJournalTable.JournalType == InventJournalType::Movement && inventJournalTable.JournalIdOrignal ||
        inventJournalTable.SystemBlocked == NoYes::Yes)
        {
            InventJournalName inventJournalName = InventJournalName::find(_journalNameId);         

            if (inventJournalName.
            && inventJournalName.JournalType == _expectedJournalType)
            {
                inventJournalTable.initFromInventJournalName(inventJournalName);
                inventJournalTable.VoucherDraw = JournalVoucherDraw::Post;
                inventJournalTable.insert();
            }

            else
            {
                throw error(strFmt("@SYS22977", _expectedJournalType));
            }
            
          
        return inventJournalTable;
    }

}

I have the same question (0)

All responses (8)

Answers (1)

HARISH MEHRA 113 on at

Like (1)

Report
Copy link

Link copied!

Thankyou for the suggestions.

I have written the logic in - Maps/InventInventoryJournalEntryMap/Methods/setJournalNumber.

And now logic is working.

Thanks & Regards,

Harish

Was this reply helpful? Yes No
Verified answer

Mohit Rampal 12,565 Moderator on at

Like (1)

Report
Copy link

Link copied!
Hi Harish, I think the issue for you is that even if you write your logic before next statement, it will work only when your conditions are not met and error is thrown. However, when your conditions are passed your code will create a record in inventJournalTable then it will then call to super which will either try to create new record or throw error, so it will be issue.

One way is to create duplicate method of createJournalHeader and call that method instead in the following two methods. You have to CoC on below methods to bypass standard logic and then call everything in your methods.

/Maps/InventInventoryJournalEntryStagingMap/Methods/postGetStagingData

/Maps/InventInventoryJournalEntryMap/Methods/setJournalNumber

Note: If you proceed with this approach, any updates on those methods by Microsoft in future will impact your solution as you will be duplicating standard method.

Was this reply helpful? Yes No
Martin Dráb 238,296 Most Valuable Professional on at

Like (0)

Report
Copy link

Link copied!

What code you should write depends on what behaviour you want to get. That's what you need to start thinking about.

One suggestion given to you is throwing an exception. Unfortunately, you've never told us whether it meets your requirements or not.

Was this reply helpful? Yes No
HARISH MEHRA 113 on at

Like (0)

Report
Copy link

Link copied!

Hi Anh,

I can write my logic before next that is fine. But the main thing here is how can I stop standard from making a new journal if conditions fail.

Thanks

Was this reply helpful? Yes No
Alex VN 1,994 on at

Like (0)

Report
Copy link

Link copied!

Hi,

In addition to Martin, to avoid confusion, the standard call will be called when you have next call on line 9. Hence you can put your own logic before line 9 to apply before standard call.

Was this reply helpful? Yes No
Martin Dráb 238,296 Most Valuable Professional on at

Like (0)

Report
Copy link

Link copied!

Yes, of course. You call the standard logic at line 9 and check your condition later, at line 11.

Was this reply helpful? Yes No
HARISH MEHRA 113 on at

Like (0)

Report
Copy link

Link copied!

Hi Martin,

Done the changes as you said.

About problem - When I am running the process the standard method creates the journal before checking my condition .

Thanks

Was this reply helpful? Yes No
Martin Dráb 238,296 Most Valuable Professional on at

Like (0)

Report
Copy link

Link copied!

Please never describe a problem by mere "not working", because it can mean absolutely anything. Instead, describe the actual behavior to us. For example, maybe you get an error and should tell us where it's thrown and what the error message says.

Your code looks syntactically wrong to me, because you're trying to call next createJournalHeader() twice, and the logic doesn't meet your requirements.

You need to think about what exactly you want to do if you condition is met. Don't you want to throw an exception, for instance?

By the way, it's not necessary to add all the tags like "dynamics 365 finance & operation". This whole forum is about F&O, therefore these tags add no information.

Was this reply helpful? Yes No

Join the conversation

Community site session details

Add my logic in extension before the standard method call in X++

Helpful resources

News and Announcements

Quick Links

Responsible AI policies

Neeraj Kumar – Community Spotlight

Congratulations to the December Top 10 Community Leaders!

Leaderboard > Finance | Project Operations, Human Resources, AX, GP, SL

Featured topics

Product updates

Community site session details

Add my logic in extension before the standard method call in X++

Helpful resources

News and Announcements

Quick Links

Responsible AI policies

Neeraj Kumar – Community Spotlight

Congratulations to the December Top 10 Community Leaders!

Subscribe to this forum!

Select categories

Leaderboard > Finance | Project Operations, Human Resources, AX, GP, SL

Featured topics

Product updates