Small and medium business | Business Central, N...

Deleting older sales orders

(0) Share

Report

Posted on by MarisolC

Hi, I haver this requirement:

I need to delete all sales orders that are more than 15 days old (it doesn´t matter if they were covered totally o partially). I wrote some code and it works perfect, BUT, this sales orders are not archived automatically and I need that they are archived.

dFechaInicio := 20220101D;

dFechaBorrar := CalcDate('<-15D>', WorkDate());

rcSalesHeader.SetRange("Order Date", dFechaInicio, dFechaBorrar);

if rcSalesHeader.FindSet() then

repeat

rcsalesLine.SetRange("Document No.", rcSalesHeader."No.");

if rcsalesLine.findset() then begin

rcsalesLine.DeleteAll();

rcSalesHeader.Delete();

end;

until rcSalesHeader.NEXT = 0;

end;

I've thingking that I need to use a different method to achive this because in fact what I want to replicate is as if user was hitting Delete button:

Finding those methods confuses me a lot.

Thanks in advance.

Categories:

Dynamics 365 Business Central

All responses (6)

Answers (0)

Suggested answer

YUN ZHU 75,802 Super User 2024 Season 2 on at

Like (1)

Report

RE: Deleting older sales orders

Hi, just adding some info.

This is mentioned in MS Learn | Docs.

https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/methods-auto/record/record-delete-method

AL code in the OnDelete Trigger for Sales Header.

So if you want to run the code in the OnDelete Trigger of the table, you should use Record.Delete(true).

In addition, the same is true for Insert, Modify, ModifyAll, DeleteAll, and OnValidate, but the executed code are in different trigger.

For example,

Hope this helps.
Thansk.

ZHU
Suggested answer

TeddyH 12,864 Super User 2024 Season 1 on at

Like (1)

Report

RE: Deleting older sales orders

Delete(true) runs the validation inside the delete logic which perform checks and delete all related tables (such as lines, dimension, etc).

Delete() or Delete(false) basically just delete without validation. Or you can call it force delete which is why the lines remained.

In general, always run the validation.
MarisolC 60 on at

Like (0)

Report

RE: Deleting older sales orders

Besides that, I don't know what makes this different:

rcSalesHeader.Delete();

first when I ran this it only deleted Sales Headers but Sales Lines where still existing which caused me another issues

from this:

rcSalesHeader.Delete(true); Here a complete delete Sales happened: Header, Lines and Archive.

I cannot fully undestand how this works.

So sorry to bohter you, I have been learning slowly and some concepts are new to me.
MarisolC 60 on at

Like (0)

Report

RE: Deleting older sales orders

Zhu, as always you are saving my day, I did run delete trigger and everything ran perfectly. Now, my doubt is, how can I knos which methods, as rcSalesHEader.Delete(true) exists and how can I know which one I need to use?

TIA!
Rebe.Gwaindepy 162 on at

Like (1)

Report
RE: Deleting older sales orders

Hi Marisun

In addition to what ZHU said, may you make sure that:

You pass the appropriate filters to your code. From the sample you sent, you are not setting the document type filter therefore the system may delete all sales documents withing the given dates (Return orders,credit memos etc)

Ensure that the Archive Orders field is ticked on sales and receivables setup because the auto archive procedure uses that condition as shown below:

Regards,

Kudah
Suggested answer

YUN ZHU 75,802 Super User 2024 Season 2 on at

Like (2)

Report

RE: Deleting older sales orders

Hi, You can run the program below manually.

Or just run delete trigger in your code.

For example, rcSalesHeader.Delete(true);

Hope this helps.

Thanks.
ZHU