You cannot request a change, because the document is in state Draft. when auto submit the workflow in ax 2012 r3

(0) Share

Report

Posted on by @rp@n

hi Team,

I have wrote code for PO auto Submit

PurchLine   purchOrderLine;

    select purchOrderLine
        where purchOrderLine.PurchId == _purchTable.PurchId
        &&    purchOrderLine.PurchPrice == 0;

    if(!purchOrderLine.RecId && _purchTable.ChangeRequestRequired == NoYes::Yes)
    {
        VersioningPurchaseOrder::newPurchaseOrder(_purchTable).createChangeRequest();
        //_purchTable.ChangeRequestRequired = NoYes::No;
        //_purchTable.doUpdate();

        _purchTable.submitToWorkflow(workFlowTypeStr(PurchTableTemplate),
                                    strFmt("Auto submit by %1",curUserId()),
                                    false);

VersioningPurchaseOrder::newPurchaseOrder(_purchTable).createChangeRequest();

When I used the above code then got below error

PurchLine   purchOrderLine;

    select purchOrderLine
        where purchOrderLine.PurchId == _purchTable.PurchId
        &&    purchOrderLine.PurchPrice == 0;

    if(!purchOrderLine.RecId && _purchTable.ChangeRequestRequired == NoYes::Yes)
    {
        //VersioningPurchaseOrder::newPurchaseOrder(_purchTable).createChangeRequest();
        _purchTable.ChangeRequestRequired = NoYes::No;
        _purchTable.doUpdate();

        _purchTable.submitToWorkflow(workFlowTypeStr(PurchTableTemplate),
                                    strFmt("Auto submit by %1",curUserId()),
                                    false);
    }

If i used,

_purchTable.ChangeRequestRequired = NoYes::No;
_purchTable.doUpdate();

*** instead of VersioningPurchaseOrder::newPurchaseOrder(_purchTable).createChangeRequest();

then it is successfully submitted.

Can you please let me know is there any difference between both code ??

VersioningPurchaseOrder::newPurchaseOrder(_purchTable).createChangeRequest();

_purchTable.ChangeRequestRequired = NoYes::No;

Please give me more shewd on this.

thanks!

I have the same question (0)

All responses (9)

Answers (1)

Sort by

Suggested answer

greengrimms 1,400 on at

Like (0)

Report
Copy link

Link copied!

Hi,

That's happening because of this piece of code:

So when you set the ChangeRequestRequired field to No, you're skipping that validation:

Also, from the functional side, the PO must be confirmed first in order to be sent to workflow (at least that's how it works in our business scenario)

Was this reply helpful? Yes No
@rp@n 56 on at

Like (0)

Report
Copy link

Link copied!

hi Danilo,

thanks for prompt response

Can you please let me know how i will achieve this with the code

VersioningPurchaseOrder::newPurchaseOrder(_purchTable).createChangeRequest();

please give me more shed on this

thanks!

Was this reply helpful? Yes No
Suggested answer

greengrimms 1,400 on at

Like (0)

Report
Copy link

Link copied!
You could replace the createChangeRequest() code for this:

if (purchTable.DocumentState == VersioningDocumentState::Draft) { // Versioning: approve change request versioningPurchaseOrder = VersioningPurchaseOrder::newPurchaseOrder(purchTable); versioningPurchaseOrder.submitChangeRequest(); versioningPurchaseOrder.approveChangeRequest(); }

Was this reply helpful? Yes No
@rp@n 56 on at

Like (0)

Report
Copy link

Link copied!
Thanks a lot

PurchLine purchOrderLine; VersioningPurchaseOrder versioningPurchaseOrder; select purchOrderLine where purchOrderLine.PurchId == _purchTable.PurchId && purchOrderLine.PurchPrice == 0; if(!purchOrderLine.RecId && _purchTable.ChangeRequestRequired == NoYes::Yes && _purchTable.DocumentState == VersioningDocumentState::Draft) { //VersioningPurchaseOrder::newPurchaseOrder(_purchTable).createChangeRequest(); // Versioning: approve change request versioningPurchaseOrder = VersioningPurchaseOrder::newPurchaseOrder(_purchTable); versioningPurchaseOrder.submitChangeRequest(); versioningPurchaseOrder.approveChangeRequest(); _purchTable.submitToWorkflow(workFlowTypeStr(PurchTableTemplate), strFmt("Auto submit by %1",curUserId()), false); }

Is it correct now?

Please give me more shed on this

thanks!

Was this reply helpful? Yes No
@rp@n 56 on at

Like (0)

Report
Copy link

Link copied!

Hi Danilo,

Now I am getting this error

Please give me more shed on this.

thanks!

Was this reply helpful? Yes No
@rp@n 56 on at

Like (0)

Report
Copy link

Link copied!
Hi Danilo,

The PO status is now DRAFT then why the below code executed and getting error

public void submitChangeRequest() { ttsbegin; if (this.getDocumentState() != VersioningDocumentState::Draft) { // Only a document in state Draft can be submitted for approval. throw error("@SYS326422"); } this.setDocumentState(VersioningDocumentState::InReview); ttscommit; }

Even i observed, the code is not go inside if loop. it directly come to this.setDocumentState(VersioningDocumentState::InReview);

but still getting the error...

please give me more shed on this

thanks!

Was this reply helpful? Yes No
@rp@n 56 on at

Like (0)

Report
Copy link

Link copied!
Hi Danilo,

I found the cause , why this error is coming

In method - SubmitToWorkflow()

public void submitToWorkflow(WorkflowTypeName _workflowTemplateName, WorkflowComment _workflowComment, boolean _activatingFromWeb = false) { ttsbegin; Workflow::activateFromWorkflowType(_workflowTemplateName, this.RecId, _workflowComment, _activatingFromWeb, curUserId()); VersioningPurchaseOrder::newPurchaseOrder(this).submitChangeRequest(); ttscommit; }

Again it is called the class

VersioningPurchaseOrder::newPurchaseOrder(this).submitChangeRequest();

Now it is getting DocumentState = INREVIEW

Due to this I am getting the error

Please let me know how i will resolve this.?

Was this reply helpful? Yes No
Verified answer

greengrimms 1,400 on at

Like (0)

Report
Copy link

Link copied!
So since you're requesting the document state change on the workflow submition method, it should work if you just keep this:

PurchLine purchOrderLine; VersioningPurchaseOrder versioningPurchaseOrder; select purchOrderLine where purchOrderLine.PurchId == _purchTable.PurchId && purchOrderLine.PurchPrice == 0; if(!purchOrderLine.RecId && _purchTable.ChangeRequestRequired == NoYes::Yes && _purchTable.DocumentState == VersioningDocumentState::Draft) { _purchTable.submitToWorkflow(workFlowTypeStr(PurchTableTemplate), strFmt("Auto submit by %1",curUserId()), false); }

Have you already try this?

I'm away from my machine right now so I'm unable to test this, but I think it should work given what we know already.

Was this reply helpful? Yes No
@rp@n 56 on at

Like (0)

Report
Copy link

Link copied!

Hi Danilo,

Now it is working fine. Thanks a lot.

Can you please let me know one more thing.

How I will identified, which user submitting the workflow?

I passed as a parameter curUserId (). As workflow is running in batch. Shall I identified the user ,who submitting the workflow ?

Please give me more shed on this

Was this reply helpful? Yes No