Microsoft Dynamics NAV (Archived)

An attempt was made to change an old version of a “Sales Line” record

(1) Share

Report

Posted on by Ghetz

3,013

So I'm working on NAV 2017, using advanced warehouse functionality:

- I create a sales order and add an item line quantity: 4

- I create a warehouse shipment for this sales order

- I create a warehouse pick and do a partial pick, so I put Qty. to Handle: 1 and register my pick

- Now when I try to register send only my Warehouse Shipment, I get this error:

"An attempt was made to change an old version of a “Sales Line” record"

Debug and see that standard code is throwing this. The call stack is basically:

CU 80 Post calls FinalizePosting -> PostUpdateOrderLine(SalesHeader); -> ModifyTempLine(TempSalesLine);

The code in ModifyTempLine is standard:

TempSalesLineLocal.MODIFY;
SalesLine := TempSalesLineLocal;
SalesLine.MODIFY; //This Line throws error

I modified this function to see if any customizations (which I'm almost sure, I don't have in this part) could be the problem, but I still get the error:

COMMIT;
TempSalesLineLocal.MODIFY;
SalesLine.GET(TempSalesLineLocal."Document Type",TempSalesLineLocal."Document No.",TempSalesLineLocal."Line No.");
SalesLine := TempSalesLineLocal;
SalesLine.MODIFY; //Still throws the error

*This post is locked for comments

I have the same question (0)

All responses (17)

Answers (0)

ManishS 86 on at

Like (0)

Report

First of all you should not use commit.

Sounds a bug to me, cause if you try to modify the current rec system through this error.

Try using a different variable and modify the record.

Was this reply helpful? Yes No
Ghetz 3,013 on at

Like (0)

Report

Even without COMMIT I get the same error. Also sounds looks like a bug to me, but nothing se can control at Code level.

Also thought about database snapshot isolation configuration, but seems like NAV is not affected by this setting.

Was this reply helpful? Yes No
Ghetz 3,013 on at

Like (0)

Report
It doesn't really make sense.

If I change the code to this, I don't get any error.

LOCAL ModifyTempLine(VAR TempSalesLineLocal : TEMPORARY Record "Sales Line") TempSalesLineLocal.MODIFY; SalesLine.GET(TempSalesLineLocal."Document Type",TempSalesLineLocal."Document No.",TempSalesLineLocal."Line No."); SalesLine."Outstanding Quantity" := TempSalesLineLocal."Outstanding Quantity"; SalesLine."Quantity Shipped" := TempSalesLineLocal."Quantity Shipped"; SalesLine."Qty. Shipped (Base)" := TempSalesLineLocal."Qty. Shipped (Base)"; SalesLine."Qty. to Ship" := TempSalesLineLocal."Qty. to Ship"; SalesLine."Qty. to Ship (Base)" := TempSalesLineLocal."Qty. to Ship (Base)"; SalesLine."Outstanding Qty. (Base)" := TempSalesLineLocal."Outstanding Qty. (Base)"; SalesLine."Qty. Shipped Not Invoiced" := TempSalesLineLocal."Qty. Shipped Not Invoiced"; SalesLine."Qty. Shipped Not Invd. (Base)" := TempSalesLineLocal."Qty. Shipped Not Invd. (Base)" ; SalesLine.MODIFY;

So, why can I assign individual fields and then MODIFY the record, but record := temprecord throws error. Also tried SalesLine.COPY(TempSalesLineLocal) and SalesLine.TRANSFERFIELDS(TempSalesLineLocal)

Both throw errors. For the momento, I'm going to have to manually copy all the affected fields, but I would like the standard code to work.

Any ideas?

Was this reply helpful? Yes No
Suggested answer

Zaid Tariq 2,274 on at

Like (0)

Report

Hi,

As far as i know you cannot use COPY and and TRANSFERFIELDS function is the record is of type Temp.

This not actually possible in NAV record := temprecord;

Thanks

Was this reply helpful? Yes No
Suggested answer

Community Member on at

Like (0)

Report
Hello Ghetz,

When you use

SalesLine := TempSalesLineLoca;

SalesLine.MODIFY;

There is a risk that you change the primary key. When you change a primary key it is a RENAME not a MODIFY.

Try this

TempSalesLineLocal.MODIFY; IF SalesLine.GET(TempSalesLineLocal.RECORDID) THEN SalesLine.DELETE(TRUE); SalesLine.INIT SalesLine := TempSalesLineLocal; SalesLine.INSERT(TRUE);

The second code you say it works... it works because you use GET before (SalesLine := TempSalesLineLocal has nothing to do with the error).

Was this reply helpful? Yes No
Ghetz 3,013 on at

Like (0)

Report

OK.. but.. does this mean the original code by Microsoft is bugged?

Actually I don't see any risk of primary key modification. The Sales Line primary key is Type, Document No. and Line No. This fields never change. They have the same value in TempSalesLineLocal and in the actual record.

I find it risky to delete de original sales Line.

Was this reply helpful? Yes No
Suggested answer

Community Member on at

Like (0)

Report

Hi,

Did you or anyoneelse find any solutions?

I am struggling With same fault...

I hav used lot of time to find solutions but not succseed.

Was this reply helpful? Yes No
martin1116 5 on at

Like (0)

Report

I used a dumb way to fix this. I went to the table field list and copied them all to Excel. Then I set SalesLine.field := TempSalesLineLocal.field on all fields except the primary key. Concatenated everything, and copied it back to codeunit 80. Worked fine so far.

Was this reply helpful? Yes No
Community Member on at

Like (0)

Report

We got exactly the same issue with Dynamics NAV 2018 in Cumulative Update 2.

The same Code is in Codeunit 90, too.

Hopefully Microsoft will fix this issue.

Was this reply helpful? Yes No
Community Member on at

Like (0)

Report
Try

RealRec.TRANSFERFIELDS(TempRec,FALSE);

This worked for me in similar situation. FALSE here means do not change source's primary key.

Was this reply helpful? Yes No