Can't seem to loop through datasource

(0) Share

Report

Posted on by Berthil

200

Hi all,

I'm trying to create the following process:

2110.weightcheck.png

(1) Get packing lines and fill them in a temp table shown in a form

(2) Loop through records and calculate total weight when button is clicked

However if the button code below is executed it loops through the same amount of rows that is in the datasource but in my case the itemid is not updated.

Any idea why?

void clicked()
{

    WHSTmpPackingLine loop = whstmppackingline_ds.getFirst();

    while (loop)
    {

        info(strFmt(WHSTmpPackingLine.ItemId));

        loop = WHSTmpPackingLine_ds.getNext();

    }

    super();
}

All responses (4)

Answers (1)

Berthil 200 on at

Like (0)

Report

RE: Can't seem to loop through datasource

Thank you for your tip! I understand the logic now. I'm not much of a programmer and just conquering the concepts of X++.
Suggested answer

vinitgoyal2005 6,330 on at

Like (1)

Report

RE: Can't seem to loop through datasource

Hi Berthil,

As mentioned by Gunjan, you need to use info(strFmt(loop.ItemId));

Also as a best practice do not use generic variables like 'loop' instead you can create variables like WHSTmpPackingLine whsTmpPackingLineloc = whstmppackingline_ds.getFirst(); and use whsTmpPackingLineloc in your logic. such code is more readable in the future by you or anyone else.
Martin Dráb 230,149 Most Valuable Professional on at

Like (1)

Report
RE: Can't seem to loop through datasource

If it's a temporary table, you can simply use a select statement:

while select whsTmpPackingLine { info(strFmt(whsTmpPackingLine.ItemId)); }

Or, if you want to take into account query ranges, you can use a query instead.

Then you can also use sum() aggregation function to calculate the total.
Verified answer

Gunjan Bhattachayya 35,421 on at

Like (1)

Report
RE: Can't seem to loop through datasource

Try this instead for the info part -

info(strFmt(loop.ItemId));