How To speed Up Nested Loop

(0) Share

Report

Posted on by AX Fourms

Hi Guys,

i Have a request that User Enter one Warehouse and many Locations
i handled the location by multiSelect
then i insert in Table Items that meets this criteria with the rest of inventDim combination

for example use choose Warehouse " X " Locations " Y,Z,N".

i must meet this criteria to find the item with the rest of inventory dimensions like Pallet,InventoryStatus,Serial Number etc..
so one item can have multiple records and the same for other items

so i made nested loop for all required dimensions and i use InventDim::FindOrCreate(myCombination) For each loop

but it takes alot of time .. can anyone help ?

All responses (2)

Answers (1)

Suggested answer

nmaenpaa 101,156 Moderator on at

Like (1)

Report

RE: How To speed Up Nested Loop

Nested loops are usually a bad idea because they are slow. You should implement similar functionality as a single loop (for example by using joins) instead.

This is a general answer to your general question.
Verified answer

Martin Dráb 231,758 Most Valuable Professional on at

Like (1)

Report
RE: How To speed Up Nested Loop

Does it mean that you're trying to find all InventDim records for the given warehouse and locations? It surely can be done by a single query.

If you wrote a select statement, you would do something like

where Warehouse == "X" and (Location == "Y" or Location = "Z" or ...)

To do dynamically, you need to use Query* classes . For example:

Query query = new Query(); QueryBuildDataSource ds = query.addDataSource(tableNum(InventDim)); ds.addRange(fieldNum(InventDim, InventLocationId)).value(queryValue('X')); ds.addRange(fieldNum(InventDim, wmsLocationId)).value(queryValue('Y')); ds.addRange(fieldNum(InventDim, wmsLocationId)).value(queryValue('Z')); ds.addRange(fieldNum(InventDim, wmsLocationId)).value(queryValue('N'));