Display method performance issue

(0) Share

Report

Posted on by Community Member

Hi everyone,

i use two display methods and i experienced a strange behavior.

I want to extend the form part EcoResProductPerCompanyPreviewPart. We want to display the current quantity in open sales lines:

My first approach was to define a display method in the form because there is no datasource and no specific relation.

Because this approach was very slow i tried another one. I added two datasources without any links and queries and moved the display methods into the datasources.

The code in the display methods is exactly the same but the second approach is much faster. Why??

Any ideas on this?

Regards

Nils

*This post is locked for comments

I have the same question (0)

All responses (7)

Answers (1)

Martin Dráb 237,965 Most Valuable Professional on at

Like (0)

Report

You could find the answer by measuring what consumes all the time in the former case.

If you want some advice from us, please show us what's inside your methods.

Was this reply helpful? Yes No
Community Member on at

Like (0)

Report
I wonder why the same code behaves different in two cases.

public display Qty getBackorderQty() { SalesLine localSalesLine; InventTable argsRecord; argsRecord = element.args().record(); select sum(RemainSalesPhysical) from localSalesLine where localSalesLine.ItemId == argsRecord.ItemId && localSalesLine.SalesStatus == SalesStatus::Backorder; return localSalesLine.RemainSalesPhysical; }

public display InventQtyAvailPhysical getAvailPhysical() { InventSum localInventSum; InventTable argsRecord; argsRecord = element.args().record(); select sum(AvailPhysical) from localInventSum where localInventSum.ItemId == argsRecord.ItemId; return localInventSum.AvailPhysical; }

Was this reply helpful? Yes No
Martin Dráb 237,965 Most Valuable Professional on at

Like (0)

Report

Maybe the code executes exactly the same, but it differs in how many times you call it (depending on where you use the display method).

Nevertheless note that performance problems are rarely solved by guessing; measuring what takes time is a much more successful approach.

Was this reply helpful? Yes No
Verified answer

KyleLeBarre 747 on at

Like (0)

Report

Form level display methods get called a ridiculous amount of times for no reason, in my experience. They also can't be cached.

I don't see a reason why you couldn't add these display methods to the InventTable (the actual table object, not the form datasource). You could decorate it with [SysClientCacheDataMethodAttribute] to have the form automatically cache it, too.

Was this reply helpful? Yes No
Community Member on at

Like (0)

Report

Thank you! I will try that tomorrow.

Regards

Nils

Was this reply helpful? Yes No
Community Member on at

Like (0)

Report

Works great!

I moved the display methods into the InventTable so there is no need to keep SalesLine and InventSum datasources in the form. Works much faster than the Form-display variant.

Thank you!

Regards Nils

Was this reply helpful? Yes No
Martin Dráb 237,965 Most Valuable Professional on at

Like (0)

Report

Caching is absolutely critical with display methods. In your case, it's enough to run your code only once (unless element.args().record() changes), while uncached display methods would run your queries again and again on every screen refresh for absolutely no reason.

You can see that you could calculate the value in linkActive() and then just display it in the form (as unbound fields or using a form-based display methods). You have many options, but in either case you must ensure yourself that you don't do more DB calls from client than necessary.

Was this reply helpful? Yes No