Skip to main content

Notifications

Announcements

Announcing Category Subscriptions!
News and Announcements icon
Dynamics 365 Community / Forums / Finance | Project Operations, Human Resources, ... / "if" condition structure
Finance | Project Operations, Human Resources, ...
Unanswered

"if" condition structure

(2) ShareShare
ReportReport
Posted on by DELDYN 304
Hi,

I want to know which code looks better and if both have the same effect

    private boolean canGenerateValue(Table1 _table1)
    {
        if(_table1 && _table1.Field1 == NoYes::No &&
            (_table1.Type == Type::A
                && Parameters::find().FieldX == NoYes::Yes 
                && Table2::find(_Table1.Id).FieldA== NoYes::Yes
             )
            ||
            (
                _table1.Type == Type::B
            )
          )
        {
            return true;
        }
        else
        {
            return false;
        }
  }


OR
 
    private boolean canGenerateValue(Table1 _table1)
    {
        if(_table1&& _table1.Field1 == NoYes::No)
        {
             if (_table1.Type == Type::A)
             {
                 if(Parameters::find().FieldX == NoYes::Yes && Table2::find(_Table1.Id).FieldA== NoYes::Yes)
                 {
                       return true;
                  }
                  else
                  {
                       return false;
                   }
             }
             else if(_table1.Type == Type::B)
             {
                 return true;
             }
             else
             {
                 return false;
             }
        }
    }
 
 
OR
 
    private boolean canGenerateValue(Table1 _table1)
    {
        if(_table1&& _table1.Field1 == NoYes::No)
        {
             if (_table1.Type == Type::A && Parameters::find().FieldX == NoYes::Yes && Table2::find(_Table1.Id).FieldA== NoYes::Yes)
             {
                  return true;
             }
             else if(_table1.ype == Type::B)
             {
                 return true;
             }
             else
             {
                 return false;
             }
        }
    }

-- and for the first option, since I have mix of && and || --- what is the best way to place them, sometimes i see the && on the same line and the || on a new line alone and sometimes the opposite
  • Martin Dráb Profile Picture
    Martin Dráb 230,370 Most Valuable Professional on at
    "if" condition structure
    1. I thought you want something else from your code, but if you want this, all right.
    2. It can't be answered. What is the best depends on context. Different situations ask for different solutions.
  • DELDYN Profile Picture
    DELDYN 304 on at
    "if" condition structure
    Hi Martin,

    1. You mentioned this sentence:
    "For example, you can do it when creating an instance, use lazy initialization (when you need the value, you'll check if it's populated and call find() if not), maybe calling postProcessing() without canGenerateValue() would be a bug that you need to prevent...
    Declaring the variable as public is a bad idea, make it either private or protected (if you want to make it accessible from child classes)."
     
     
    So i wrote the code in green to show you if what i did is what u were thinking about or not  -- what do you think?



    2. and in general, what is better

    if(this.CanGenrateValue())
    {
      this.generateValue();
    }

    or to call this.CanGenrateValue() inside this.generateValue();
     
  • Martin Dráb Profile Picture
    Martin Dráb 230,370 Most Valuable Professional on at
    "if" condition structure
    2. You can if you want.
    1. Neither your code in green is not related Class1_TypeA_Extension and Class1_TypeB_Extension. My answer to your question "what do u want me to do in the other two classes:  Class1_TypeA_Extension, Class1_TypeB_Extension?" is "Noting. We never talked about them before". If you have a question about your new code (in green), please write the question down. But keep in mind that the topic of this thread is "if" condition structure.
  • DELDYN Profile Picture
    DELDYN 304 on at
    "if" condition structure
    Hi Martin,

    2. So shall i stick with my code?

    1. but i showed you in a previous reply what i did by adding code in green, but i didn't get what is wrong in it from your comment
  • Martin Dráb Profile Picture
    Martin Dráb 230,370 Most Valuable Professional on at
    "if" condition structure
    2. Aha, I see it now.
     
    1. There is nothing to do with Class1_TypeA_Extension and Class1_TypeB_Extension, because Table3 is not used there. Let me remind you that your question was "How can i avoid selecting table3 twice".
  • DELDYN Profile Picture
    DELDYN 304 on at
    "if" condition structure
    Hi Martin,

    2. I mean, that i want to pass the updated value of Table1, that's why I had to do this



    1. I don't get what u mean, what do u want me to do in the other two classes:  Class1_TypeA_Extension, Class1_TypeB_Extension?
    So is what i did in the last reply not what you wanted?
  • Martin Dráb Profile Picture
    Martin Dráb 230,370 Most Valuable Professional on at
    "if" condition structure
    2. I don't understand what you're trying to tell me. I don't pass table1Update to nextPosting() because it's impossible and it would be logically wrong.
     
    1. I was talking about all classes, not just final ones.
  • DELDYN Profile Picture
    DELDYN 304 on at
    "if" condition structure
     
    Hi Martin,

    2. But in your solution you are passing table1 to nextPosting(table1)  instead of table1Update and i won't be able to pass table1Update if you define it inside the ttsbegin. That's why I had to do this 
    Table1 table1 = _table1;
    1. we can't declare protected variables in extensions. And sorry i meant if we call generateValue without canGenerateValue, fieldD will always be empty -- So i think i can do sth like this (check green changes please):
    [ExtensionOf(classStr(Class1))]
    final class Class1_Extension
    {
       private str fieldD;
     
    public boolean canGenerateValue(Table1 _table1)
    {
        if (!_table1 || _table1.Field1 == NoYes::Yes)
        {
            return false;
        }
     
        fieldD = Table3::find(_table1.CustAccount).FieldD;  // i think it's better to not include this in the first or condition in order to not select this table if the first condition will fail what do you think?
        if(!fieldD)
        {
           return false;
        }
     
        switch (_table1.Type)
        {
            case Type::A:
                return Parameters::find().FieldX && Table2::find(_table1.Id).FieldA;
            case Type::B:
                return true
        }
        
        return false;
    }
     public str generateValue(Table1 _table1)
        {
                 str value;   
                //logic
                            if(!fieldD)
                            {
                               return '';
                            }
                    Table1 table1Count;
               
                    select count(RecId) from table1Count
                        where table1Count.Id2 == _table1.Id2;
                    if(table1Count.RecId == 1)
                    {
                       //logic
                        if(//logic)
                        {
                              //logic
                              value = //logic
                        }
                        else
                        {
                            //logic
                            value = fieldD + todayDate + //logic;
                        }
                    }
                    
                
            return value;
        }
    }
  • Martin Dráb Profile Picture
    Martin Dráb 230,370 Most Valuable Professional on at
    "if" condition structure
    2. I know you're using table1 and _table1, my point is that you reuse table1. You assign a value there twice.
    1. What you mean is an instance variable, not a global variable. You can store there either FieldD or Table3. If you're saying that your design populating the value in canGenerateValue() is wrong, then fix it. How to do it depends on your requirements. For example, you can do it when creating an instance, use lazy initialization (when you need the value, you'll check if it's populated and call find() if not), maybe calling postProcessing() without canGenerateValue() would be a bug that you need to prevent...
    Declaring the variable as public is a bad idea, make it either private or protected (if you want to make it accessible from child classes).
     
    But we're off-topic here, because this has nothing to do with "if" condition structure.
  • DELDYN Profile Picture
    DELDYN 304 on at
    "if" condition structure
    Hi Martin,

    For point 2, I'm already using two variables (table1 and _table1), i think the difference then, between my approach and yours, is that you defined the 2nd variable inside the ttsbegin and that you called it table1Update instead of table1.
    but u passed _table1 in next postPosting(_table1) instead of table1Update and I want to pass table1Update. what do you think?

    For point1, you mean to define FieldD  in class1 as a global variable? and then fill it's value in method "canGenerateValue" and at the end call fieldD directly inside "generateValue()" method? like the code below?
    but now if someone doesn't want to call canGenerateValue, when they call postProcessing, fieldD will always be empty, so i wanted to force filling the varaible somehow, that's why i called Table3::find twice in the previous reply... what do you think? 
    [ExtensionOf(classStr(Class1))]
final class Class1_Extension
{
   public str fieldD;

public boolean canGenerateValue(Table1 _table1)
{
    fieldD = Table3::find(_table1.CustAccount).FieldD;

    if (!_table1 || _table1.Field1 == NoYes::Yes || !fieldD)
    {
        return false;
    }
    switch (_table1.Type)
    {
        case Type::A:
            return Parameters::find().FieldX && Table2::find(_table1.Id).FieldA;
        case Type::B:
            return true
    }
    
    return false;
}

 public void generateValue(Table1 _table1)
    {
             str value;   

            //logic


                Table1 table1Count;
           
                select count(RecId) from table1Count
                    where table1Count.Id2 == _table1.Id2;
                if(table1Count.RecId == 1)
                {
                   //logic
                    if(//logic)
                    {
                          //logic
                          value = //logic
                    }
                    else
                    {
                        //logic
                        value = fieldD + todayDate + //logic;
                    }
                }
                
            
        return value;
    }
}

Under review

Thank you for your reply! To ensure a great experience for everyone, your content is awaiting approval by our Community Managers. Please check back later.

Helpful resources

News and Announcements

Announcing Category Subscriptions!

Quick Links

photo of Muhammad Affan

December Spotlight Star - Muhammad Affan

Congratulations to a top community star!

thumbnail image of a pie chart section

Top 10 leaders for November!

Congratulations to our November super stars!

thumbnail image of the word Tip

Tips for Writing Effective Verified Answers

Best practices for providing successful forum answers ✍️

Leaderboard

#1
André Arnaud de Calavon Profile Picture

André Arnaud de Cal... 291,359 Super User 2024 Season 2

#2
Martin Dráb Profile Picture

Martin Dráb 230,370 Most Valuable Professional

#3
nmaenpaa Profile Picture

nmaenpaa 101,156

Leaderboard

Featured topics

End-of-life Announcement for Microsoft Dynamics GP

Product updates

Dynamics 365 release plans