Writing records to a Comment Table

(0) Share

Report

Posted on by Community Member

This function is meant to write a record into the Purchase comment line table however I keep getting an error

This is my code written on the Purchase Line Table

IF QuantityChange THEN BEGIN
IF PurchHeader."Released Once" THEN BEGIN
IF Quantity <> xRec.Quantity THEN BEGIN
recPurchCommentLine.RESET;
recPurchCommentLine.SETRANGE("Document Type", "Document Type");
recPurchCommentLine.SETRANGE("No.", "Document No.");
recPurchCommentLine.SETRANGE("Document Line No.", "Line No.");
recPurchCommentLine.SETRANGE("Comment Type", recPurchCommentLine."Comment Type"::PurchChange);
IF recPurchCommentLine2.FINDLAST THEN
recPurchCommentLine."Line No." := recPurchCommentLine2."Line No."
ELSE
recPurchCommentLine."Line No." := 1000;
recPurchCommentLine."Comment Type" := recPurchCommentLine."Comment Type"::PurchChange;
recPurchCommentLine.Comment :=
STRSUBSTNO(
Text107,
"Line No.",
xRec.Quantity,
Quantity);
recPurchCommentLine.Date := WORKDATE;
recPurchCommentLine.INSERT;
END;
END;
END ELSE

All feedback is appreciated!

*This post is locked for comments

I have the same question (0)

All responses (12)

Answers (1)

Suggested answer

IshwarSharma 729 on at

Like (0)

Report

Please correct your code and try this,

recPurchCommentLine.INIT; //You must INIT the record variable (of the table) before inserting new records in it.

IF recPurchCommentLine2.FINDLAST THEN

recPurchCommentLine."Line No." := recPurchCommentLine2."Line No." + 10000

ELSE

recPurchCommentLine."Line No." := 10000;

Assign the correct Line No. as shown in the code above. Hence, if records already exist in the table then you need to iterate the new record you're inserting by 10K.

Was this reply helpful? Yes No
Community Member on at

Like (0)

Report

Thank you, I've made these adjustments but still getting the error.

Is this possibly due to records in my table rather then the code??

IF QuantityChange THEN BEGIN

IF PurchHeader."Released Once" THEN BEGIN

IF Quantity <> xRec.Quantity THEN BEGIN

CLEAR(recPurchCommentLine);

recPurchCommentLine.INIT;

recPurchCommentLine.RESET;

recPurchCommentLine.SETRANGE("Document Type","Document Type");

recPurchCommentLine.SETRANGE("No.", "Document No.");

recPurchCommentLine.SETRANGE("Document Line No.", "Line No.");

IF recPurchCommentLine2.FINDLAST THEN

recPurchCommentLine."Line No." := recPurchCommentLine2."Line No." + 10000

ELSE

recPurchCommentLine."Line No." := 10000;

recPurchCommentLine."Comment Type" := recPurchCommentLine."Comment Type"::PurchChange;

recPurchCommentLine.Comment :=

STRSUBSTNO(

Text107,

"Line No.",

xRec.Quantity,

Quantity);

recPurchCommentLine.Date := WORKDATE;

recPurchCommentLine.INSERT;

END;

END;

END ELSE

Was this reply helpful? Yes No
Suggested answer

IshwarSharma 729 on at

Like (0)

Report

Please add the following code as well,

recPurchCommentLine.Validate("Document No.","Document No.");

recPurchCommentLine.Validate("No.","No.");

recPurchCommentLine.Validate("Document Line No.","Line No.");

Add this code after INIT. Is this a function OR have you written this code in a particular trigger in Purchase Line Table?

Was this reply helpful? Yes No
Suggested answer

Suresh Kulla 50,245 Super User 2025 Season 2 on at

Like (0)

Report

use the below code and declare a variable of type integer LineNo.

F PurchHeader."Released Once" THEN BEGIN

IF Quantity <> xRec.Quantity THEN BEGIN

recPurchCommentLine.RESET;

recPurchCommentLine.SETRANGE("Document Type", "Document Type");

recPurchCommentLine.SETRANGE("No.", "Document No.");

recPurchCommentLine.SETRANGE("Document Line No.", "Line No.");

recPurchCommentLine.SETRANGE("Comment Type", recPurchCommentLine."Comment Type"::PurchChange);

IF recPurchCommentLine.FINDLAST

LineNo := recPurchCommentLine."Line No." + 10000

ELSE

LineNo:= 10000;

recPurchCommentLine.INIT;

recPurchCommentLine."Document Type" := "Document Type";

recPurchCommentLine."No." := "Document No.";

recPurchCommentLine."Document Line No." := "Line No.";

recPurchCommentLine."Line No." := LineNo;

recPurchCommentLine."Comment Type" := recPurchCommentLine."Comment Type"::PurchChange;

recPurchCommentLine.Comment :=

STRSUBSTNO(

Text107,

"Line No.",

xRec.Quantity,

Quantity);

recPurchCommentLine.Date := WORKDATE;

recPurchCommentLine.INSERT;

END;

END;

Was this reply helpful? Yes No
Community Member on at

Like (0)

Report

It's a function which is called when the Qty on a purchase Line is changed.

I'm getting the "A field from a record variable was expected." when trying to add the Validate Lines.

Was this reply helpful? Yes No
Suggested answer

Suresh Kulla 50,245 Super User 2025 Season 2 on at

Like (0)

Report

By using the above code ? when you compile where is the cursor highlight ?

Was this reply helpful? Yes No
Suggested answer

IshwarSharma 729 on at

Like (0)

Report

I hope there isn't any customized code in Purch. Comment Line table in your database. Instead of validate try add these lines after INIT,

recPurchCommentLine."Document Type" := "Document Type";

recPurchCommentLine."No." := "Document No.";

recPurchCommentLine."Document Line No." := "Line No.";

Adding this code might fix the error. But also check why you are getting this error, try to debug the code and let us know.

Was this reply helpful? Yes No
Community Member on at

Like (0)

Report

Ok so I've made the changes and i'm no longer receiving the error. However I ran through debugger and it goes throgh the code as it should, but when I check the comment table there's no entry. As if the INSERT isnt working??

Was this reply helpful? Yes No
Suggested answer

Suresh Kulla 50,245 Super User 2025 Season 2 on at

Like (0)

Report

Send us the code you have finally used.

Was this reply helpful? Yes No
Verified answer

Community Member on at

Like (0)

Report

I Have Moved it over to a codeunit.

CreateCPurchaseOrderComment(QuantityChange : Boolean;DateChange : Boolean;Purchheader : Record "Purchase Header";recPurchLine : Record "Purchase Line";xRec : Record "Purchase Line")

IF QuantityChange THEN BEGIN

IF Purchheader."Released Once" THEN BEGIN

IF recPurchLine.Quantity <> xRec.Quantity THEN BEGIN

recPurchCommentLine.INIT;

{recPurchCommentLine."Document Type" := "Document Type";

recPurchCommentLine."No." := "Document No.";

recPurchCommentLine."Document Line No." := "Line No.";}

recPurchCommentLine.RESET;

recPurchCommentLine.SETRANGE("Document Type",recPurchLine."Document Type");

recPurchCommentLine.SETRANGE("No.", recPurchLine."Document No.");

recPurchCommentLine.SETRANGE("Document Line No.", recPurchLine."Line No.");

recPurchCommentLine.SETRANGE("Comment Type", recPurchCommentLine."Comment Type"::PurchChange);

IF recPurchCommentLine2.FINDLAST THEN

intLineNo := recPurchCommentLine."Line No." + 10000

ELSE

intLineNo := 10000;

recPurchCommentLine."Comment Type" := recPurchCommentLine."Comment Type"::PurchChange;

recPurchCommentLine.Comment :=

STRSUBSTNO(

Text107,

recPurchLine."Line No.",

xRec.Quantity,

recPurchLine.Quantity);

recPurchCommentLine.Date := WORKDATE;

recPurchCommentLine.INSERT(TRUE);

END;

END;

Was this reply helpful? Yes No