Finance | Project Operations, Human Resources, ...

Form datasource re-trigger displayOption method in MS D365

(0) Share

Report

Posted on by Maris Sausins

Hello!

I'm pretty new in all of this, so sorry if I ask some dumb questions.

My assignment is to change colors for the records of employee calendar, based on some criteria. Color codes I store in the Map and using debugger I can see that displayOption() method is getting correct color codes.

My problem is when I open employee calendar form, and for the current period calendar isn't generated, then even for the rest of the periods displayOption haven't been triggered, but if I generate the calendar for the current period and reopen the calendar form, then colors are displayed for every period correctly. What can be the problem here?

I hope someone can understand what I wrote here!

My displayOptions method:

public void displayOption(Common _p1, FormRowDisplayOption _options)
{
int textColor = 0;
int backColor = 0;

[textColor, backColor] = PRMEmpWorkDaysColor.getForEmpWorkDays(_p1);

if (textColor != 0)
_options.textColor(textColor);

if (backColor != 0 )
_options.backColor(backColor);

super(_p1, _options);

}

And my period modified() method:

[Control("String")]
class PeriodIdFilter
{
public boolean modified()
{
boolean ret;

ret = super();

PRMPeriodId = PeriodIdFilter.valueStr();
PRMPeriod = PRMPeriod::find(PRMPeriodId);
filterStart = PRMPeriod.Start;

PRMEmpWorkDays_ds.executeQuery();
element.updateParts();

return ret;
}

}

I have the same question (0)

All responses (14)

Answers (0)

WillWU 22,361 on at

Like (1)

Report
Hi Maris Sausins,

Could you please provide screenshot of your form?

And I formatted your code here:

public void displayOption(Common _p1, FormRowDisplayOption _options) { int textColor = 0; int backColor = 0; [textColor, backColor] = PRMEmpWorkDaysColor.getForEmpWorkDays(_p1); if (textColor != 0) _options.textColor(textColor); if (backColor != 0 ) _options.backColor(backColor); super(_p1, _options); }

[Control("String")] class PeriodIdFilter { public boolean modified() { boolean ret; ret = super(); PRMPeriodId = PeriodIdFilter.valueStr(); PRMPeriod = PRMPeriod::find(PRMPeriodId); filterStart = PRMPeriod.Start; PRMEmpWorkDays_ds.executeQuery(); element.updateParts(); return ret; } }

Was this reply helpful? Yes No
Maris Sausins 21 on at

Like (0)

Report

Hello Will!

Thanks for your response!

When I open the form and the calendar for the employee is generated for default period, everything is okay:

if calendar is not generated for default period:

and when I change the period, colors hasn't applied.

But when I was using debuger to test if displayOptions get color codes, it recieves them. Looks like everything has to work.

P.S. thanks for code formatting, not familiar with the environment yet.

Best regards
Maris

Was this reply helpful? Yes No
Suggested answer

Maris Sausins 21 on at

Like (0)

Report

Hello Will!

Can you please help me with the problem, do You have any idea what wrong with the solution?

Kind regards,
Maris

Was this reply helpful? Yes No
Suggested answer

Maris Sausins 21 on at

Like (0)

Report

Hi Pete!

Thanks for your time.

What do you mean by a standard form? Is this a D365 system form, then not it's custom made.

Or you meant something else?

Was this reply helpful? Yes No
Pete Alberts 3,542 on at

Like (1)

Report

Hi Maris

I deleted my comment because it is clear that the form is indeed your own.

I will get back to you soon.

Was this reply helpful? Yes No
Suggested answer

Pete Alberts 3,542 on at

Like (0)

Report
So if I try to simplify the problem. The displayOption works correctly initially, but when you refresh the data (executeQuery), then it appears to magically have disappeared. Please let me know if I missed something there.

That comes down to a displayOption and a filter. To test I created a SimpleList form for the CustTable table.

The code to achieve a display option with a filter will look like this:

[Form] class XYZDisplayOptionTest extends FormRun { private QueryBuildRange custGroupRange; [DataSource] class Customer { void init() { super(); custGroupRange = this.queryBuildDataSource().addRange(fieldNum(CustTable,CustGroup)); } void displayOption(Common _p1, FormRowDisplayOption _options) { _options.textColor(65408); _options.backColor(20000); super(_p1, _options); } } [Control("String")] class CustGroupFilter { boolean modified() { boolean modified; modified = super(); custGroupRange.value(this.text()); Customer_ds.executeQuery(); return modified; } } }

The form design looks like this:

Which works as expected:

Which means some of your own code somewhere someplace is causing trouble. Exactly what code that is will be difficult from my side. If I were you I'd comment out everything and start with just the display option and the filter. Then it must work. When you get there you can start gradually adding back your logic.

If you paste all your code I can try and look with you for the problem. But I don't know if you are comfortable with that.

Was this reply helpful? Yes No
Pete Alberts 3,542 on at

Like (0)

Report
From the code that Will Wu formatted:

What type of object is PRMEmpWorkDaysColor?

I assume you set the range in PRMEmpWorkDays_ds.executeQuery() method?

I'd start by looking at what happens in the updateParts() form method.

As you mentioned being new, a few comments:

We always need to add curly brackets around an if-statement even if it only contains a single line of code (also while, for, etc). It really sucks. But that is how it is. It's best practice and you'll notice the code editor struggles with the indentation if you do not add brackets.

Methods in x++ are implicitly public, so I tend to remove the public. But that is my preference.

X++ primitives do not need to be initialised. Int will be 0, boolean false, string will be "", etc

Was this reply helpful? Yes No
Maris Sausins 21 on at

Like (0)

Report
Thanks Pete for your work! Really appreciated.

Thanks for Your recommendations!

Now I'm gonna go through everything you wrote and try to understand it.

About the code:

1. PRMEmpWorkDaysColor is a class.

2. Yes, the range is using QueryFilter.

public void executeQuery() { RecId recId; PRMEmployeeId localEmployeeId; TransDate filterEnd; if (PRMEmpWorkDays) { recId = PRMEmpWorkDays.RecId; localEmployeeId = PRMEmpWorkDays.EmployeeId; } if (filterStart) { filterEnd = endmth(filterStart); qfPeriod.value(queryRange(filterStart, filterEnd)); } else { qfPeriod.value(queryRange(datenull(), datemax())); } if (employeeId) { findOrCreateRange_W(this.queryBuildDataSource(), fieldnum(PRMEmpWorkDays, EmployeeId), queryValue(employeeId)); } super(); if (RecId) { if (!PRMEmpWorkDays_ds.positionToRecordByValue(fieldnum(PRMEmpWorkDays, RecId), int642str(RecId))) { PRMEmpWorkDays_ds.positionToRecordByValue(fieldnum(PRMEmpWorkDays, EmployeeId), localEmployeeId); } } element.updateParts(); }

3. For my understanding, there is nothing, but the accesRight check, before updating form part. (I still don't understand it much yet)

public void updateParts() { Object partFormRun; AccessRight accessRight = AccessRight::NoAccess; accessRight = SecurityRights::construct().menuItemAccessRight(SecurableType::MenuItemDisplay, menuitemDisplayStr(PrmEmpWorkDaysNewPart)); // Check access right level before attempting to update form part data if (accessRight == AccessRight::Delete) { partFormRun = PRMGlobal::getFormPartByName(element, identifierStr(PrmEmpWorkDaysNewPart)); if (partFormRun) { partFormRun.updateData(PRMEmpWorkDays.EmployeeId, dateStartMth(PRMEmpWorkDays.DayDate), endmth(PRMEmpWorkDays.DayDate)); } } accessRight = SecurityRights::construct().menuItemAccessRight(SecurableType::MenuItemDisplay, menuitemDisplayStr(PrmEmpWorkDaysDisabilityPart)); // Check access right level before attempting to update form part data if (accessRight == AccessRight::Delete) { partFormRun = PRMGlobal::getFormPartByName(element, identifierStr(PrmEmpWorkDaysDisabilityPart)); if (partFormRun) { partFormRun.updateData(PRMEmpWorkDays.EmpDisabilityId, dateStartMth(PRMEmpWorkDays.DayDate), endmth(PRMEmpWorkDays.DayDate)); } } accessRight = SecurityRights::construct().menuItemAccessRight(SecurableType::MenuItemDisplay, menuitemDisplayStr(PrmEmpWorkDaysNonAttendancePart)); // Check access right level before attempting to update form part data if (accessRight == AccessRight::Delete) { partFormRun = PRMGlobal::getFormPartByName(element, identifierStr(PrmEmpWorkDaysNonAttendancePart)); if (partFormRun) { partFormRun.updateData(PRMEmpWorkDays.EmpNonAttendanceId, dateStartMth(PRMEmpWorkDays.DayDate), endmth(PRMEmpWorkDays.DayDate)); } } }

I will try to get it done by myself, but if I won't be able to do it I will get back to you, if that's okay?

Best regards,

Maris

Was this reply helpful? Yes No
Maris Sausins 21 on at

Like (0)

Report

About the problem:

In system parameters I can set default period, for example 2020-10, then if I open the form and there is no calendar generated for the employee, then there are no colors displayed in any period, but if I change system default period, to some period where employees calendar is generated, then colors appear on every period if I change the period. If I generate the calendar for employee in that period and reopen the form, then everything is working fine.

I hope you understood something

Was this reply helpful? Yes No
Pete Alberts 3,542 on at

Like (0)

Report

"I will try to get it done by myself, but if I won't be able to do it I will get back to you, if that's okay?" You are welcome, I'll help when I get the time though.

On your second reply. I find it difficult to keep track as I am not familiar with the functional side. If I put it as simple as possible: "If the calendar is generated and you open the form then it works, otherwise not." Correct?

Was this reply helpful? Yes No