Process Code Quality Check for internal and external team members

(0) Share

Report

Posted on by Chicinho54

Hi Folks,

we have an Implementation Partner for D365 Finance. This partner is also helping us in developing customizations in X++. We have constant debates about code quality. Does someone have experience whit these kind of scenarios? What we want to do now is a clear process of code quality check. This process should be valid for our internal developers as well for our partner.

I am currently checking the tools "CAR Report", "AppChecker" and "Best Practice Rule Analyzer" and trying to understand how they can help to define such a code quality process.

I would appreciate any kind of discussion, sharing experiences or some links or even concrete tips.

Nice weekend and cheers,

Chicinho

I have the same question (0)

All responses (7)

Answers (1)

Verified answer

TsutomuYanagida on at

Like (0)

Report

Code Best Practice framework may help...

docs.microsoft.com/.../author-best-practice-rules

Was this reply helpful? Yes No
Suggested answer

Sergei Minozhenko 23,093 on at

Like (1)

Report

Hi Cihan,

BP checks and AppChecker can improve the quality of your code and could help you to identify potential issues in your code. You can automate this process by gated check-in ( docs.microsoft.com/.../check-folder-controlled-by-gated-check-build-process ) that will trigger build and run validation after the code is successfully compiled. Also, there are tasks that are available on DevOps marketplace which can help with the BP part ( for example marketplace.visualstudio.com/items). If during gated check-in build BP issues will be found, the code will be not included in the dev branch and the developer should fix it.

AppChecker could be a bit difficult to set up (but still doable) because it requires Java to be installed and other components.

An additional (and quite important) step in code quality check, is the code review made by another person. It could help to identify issues in the design itself (for example non-optimal select statement, code duplication, rules in development that are mandatory in the company).

Unfortunately, I didn't find a way to make a code review mandatory for TFVC gated check-in.

Was this reply helpful? Yes No
Chicinho54 96 on at

Like (0)

Report

Hi Sergei,

thank you very much for your feedback.

What is for you the difference between BP Checks, AppChecker and CAR Report?

We have enabled Gated Check in already and we have found a solution to make a code review. We are checking via Powershell if the shelveset which you are trying to check in, has also a work item of type "Code Review" and has the status "Looks Good". If you need here help, just write me.

I am really disappointed from X++ Development as a developer.

Why is GIT still not standard in X++ Development?

Why is their no one public website for X++ Development news?

Where it is described what is difference between Best Practices Rules in Visual Studio, CAR Report and the Application Checker?

TFS as Source Control with X++ has a lot of bugs (e.g. renaming never worked for me), why are theire no improvements or bugfixes?

Is it now possible and officially supported to use a own machine for X++ development instead of having a VM (dowloaded or cloud hosted)?

Itellisense is full of bugs and slow?

No static code analysis

No automatic Configuration Mangement

Is Visual Studio 2019 now supported or not?

Imagine what kind of support you get in case of ASP.NET Development, .NET Developmen, C# Development, Laravel etc.

Cheers,

Chico

Was this reply helpful? Yes No
Sergei Minozhenko 23,093 on at

Like (1)

Report

Hi Chico,

About code review, thank you for sharing your solution, I think I will try it.

Few additional comments:

1. Git is not officially supported, but there are a lot of articles on how to use it with x++ development

2. There were plans to start using local VS for development but looks like it was postponed.

3. No static code analysis - what kind of static code analysis do you mean? BP and App checker tools are static code analysis tools

4. VS 2017 is supported at the moment, not sure what kind of benefits you want to get out of VS 2019 in terms of x++ development.

5. CAR report and BP checks are basically the same thing, CAR report is built on top of BP checks. Application checker is a tool that allows you also to do static code analysis and explore your code. AppChecker rules and BP check rules can be overlapping

6. You can always share your overall experience\bugs in the community or in the Insider program Yammer group to get noticed. In my opinion, if you don't provide feedback you don't get a better product.

Was this reply helpful? Yes No
Chicinho54 96 on at

Like (0)

Report

Hi Sergei,

I am constantly sharing my experience in D365 with the community and also trying to give something back - this means I care.

From where do you have all your informations? Experience based or something else?

I can imagine that Microsoft is trying to make X++ Development more fun. I think it is again a matter of priorization and obviously X++ professionell Development is not at the top.

So i would expect minimum a website dedicated to X++ Development with clear statements like:

- VS2019 is not supported but maybe will be

- Git is currently not supported maybe will be by the end of 2021

- When to use CAR, BP Framework and the AppChecker

etc.

Thank you so much for your feedbacks.

Cheers,

Chico

Was this reply helpful? Yes No
Suggested answer

nmaenpaa 101,162 Moderator on at

Like (1)

Report

Hi Cihan,

most of that info you will find in MS docs but it's scattered. Also if you're not already a part of the Insider program, you should join. Then you get access to D365FO R&D Feedback Yammer group where you can interact with the D365FO product team directly.

experience.dynamics.com/

About Git, I think it will not be "supported", but what kind of support would you like to have? After all it all comes down to versioning text files in your repository. Not much D3655FO specific. I haven't tried it but I know many companies are using it and it's working.

Was this reply helpful? Yes No
Chicinho54 96 on at

Like (0)

Report

My only fear when it comes to GIT-Integration is that we will have issues with the LCS Integration. What do you think?

Was this reply helpful? Yes No