In x++ Import Update

(0) Share

Report

Posted on by Riyas ahamed F

1,215

Hi guys,

i have a update two record in PositionID and Description

"Record 000001Employee Num 000001 doesn't exist"

"Record 000001Employee Num 000002 doesn't exist:

below my code.

private void importPositionDescription()
    {
        int                             rowNo, counter, inserted;
        HcmPosition                     hcmPosition;
        HcmPositionDetail               hcmPositionDetail;
        HcmPositionId                   positionId;
        OfficeOpenXml.ExcelRange        columnVal;
        OfficeOpenXml.ExcelRange        colValNum;
        rowNo=2;

        if (dialog.run() && dialog.closedOk())
        {
            FileUpload fileUploadControl     = dialog.formRun().control(dialog.formRun().controlId("Upload"));
            FileUploadTemporaryStorageResult fileUploadResult = fileUploadControl.getFileUploadResult();
        
            if (fileUploadResult != null && fileUploadResult.getUploadStatus())
            {
                stream = fileUploadResult.openResult();
            
                using (ExcelPackage Package = new ExcelPackage(stream))
                {
                    Package.Load(stream);
                    ExcelWorksheet  worksheet   = package.get_Workbook().get_Worksheets().get_Item(1);

                    OfficeOpenXml.ExcelRange    range       = worksheet.Cells;

                    while (range.get_Item(rowNo,1).Value)
                    {

                        setPrefix(strFmt("@MPL425",range.get_Item(rowNo,1).Value));

                        try
                        {
                            positionId = range.get_Item(rowNo,1).Value;

                           /* hcmPosition = HcmPosition::find(hcmPositionDetail.Position);
                            if(hcmPosition)
                            {
                                ttsbegin;
                                hcmPosition.selectForUpdate(true);
                                hcmPosition.PositionId = range.get_Item(rowNo,2).Value;
                                hcmPosition.doUpdate();
                                ttscommit;
                            }*/
                            hcmPositionDetail = hcmPositionDetail::findByPosition(hcmPosition.RecId);
                            if(hcmPositionDetail)
                            {
                                ttsbegin;
                                hcmPositionDetail.selectForUpdate(true);
                                hcmPositionDetail.Description_AR = range.get_Item(rowNo,2).Value; 
                                hcmPositionDetail.doUpdate();
                                ttscommit;
                            }
                            
                            else
                            {
                                warning(strFmt("@MPL800",positionId));
                            }
                            rowNo  ;
                            counter  ;
                        }
                        catch (Exception::Error)
                        {

                            counter  ;
                            rowNo  ;
                            continue;
                        }

                    }
                }
            }
        }

        info(strFmt("@MPL426",counter));
    }

what did i mistake.

Thanks.

I have the same question (0)

All responses (19)

Answers (4)

Suggested answer

Martin Dráb 237,976 Most Valuable Professional on at

Like (0)

Report
The first mistake is mixing all the code in a single method. Why would you (and we) have to deal with all the stuff about file upload, Excel etc. if the actual problem is about working with AX tables?

You also forgot to mention where your code fails.

It seems that the relevant code is this:

HcmPosition hcmPosition; /* hcmPosition = HcmPosition::find(hcmPositionDetail.Position); if(hcmPosition) { ttsbegin; hcmPosition.selectForUpdate(true); hcmPosition.PositionId = range.get_Item(rowNo,2).Value; hcmPosition.doUpdate(); ttscommit; }*/ if (hcmPositionDetail) { ttsbegin; hcmPositionDetail.selectForUpdate(true); hcmPositionDetail.Description_AR = range.get_Item(rowNo,2).Value; hcmPositionDetail.doUpdate(); ttscommit; } else { warning(strFmt("@MPL800",positionId)); }

Now it's easy to see a problem - you commented out the code populating hcmPosition, therefore it'll always be empty.

Was this reply helpful? Yes No
Martin Dráb 237,976 Most Valuable Professional on at

Like (0)

Report

Another bug is that you're trying to update empty records. If you want to update an error (and not create a new one), you must first read it from a table.

Was this reply helpful? Yes No
Riyas ahamed F 1,215 on at

Like (0)

Report

Thanks for your replay martin,

actually PositionID Primary key so we can't update , now to to rewrite above the logic to

in my excel sheet

PositionID Ar Description

000001, Description

000001, Name

getting error "Record 000001Employee Num 000001 doesn't exist"

"Record 000001Employee Num 000002 doesn't exist:

Was this reply helpful? Yes No
Riyas ahamed F 1,215 on at

Like (0)

Report

How to overcome that issue.

Was this reply helpful? Yes No
Suggested answer

nmaenpaa 101,162 Moderator on at

Like (1)

Report

You are not updating the primary key, you are updating Description_AR field.

You use the primary key to find the record that you attempt to update. Your error message means that there is no such record. For example, you don't have a record for PositionId 000001, but you try to update such record.

Was this reply helpful? Yes No
Riyas ahamed F 1,215 on at

Like (0)

Report

Thanks for your replay Nikolaos Mäenpää,

please give us a Example how to Position ID "000001" against update to Description.

Was this reply helpful? Yes No
Suggested answer

nmaenpaa 101,162 Moderator on at

Like (0)

Report

You must find/select the record by calling HcmPosition::findByPosition. Then you need to check if you found something. And finally you can update it.

Was this reply helpful? Yes No
Verified answer

Martin Dráb 237,976 Most Valuable Professional on at

Like (0)

Report
It would be something like this:

HcmPosition hcmPosition = HcmPosition::findByPosition('abcd'); if(hcmPosition) { ttsbegin; HcmPositionDetail hcmPositionDetail = HcmPositionDetail::findByPosition( hcmPosition.RecId, DateTimeUtil::utcNow(), DateTimeUtil::utcNow(), true); if (hcmPositionDetail) { hcmPosition.Description_AR = 'new description'; hcmPosition.update(); } ttscommit; }

It might be a bit more complex, depending on your needs, because it's a date-effective table.

Also note that you could simply export the Excel file through "Position details" entity.

Was this reply helpful? Yes No
Verified answer

mhdshb1 1,250 on at

Like (0)

Report
Hi Ahmad,

as mentioned above an example can be

HcmPosition position = HcmPosition::findByPosition(positionId,true); if(position.recId!=0) { //update }

Regards,

M

Was this reply helpful? Yes No
mhdshb1 1,250 on at

Like (0)

Report

@Martin i guess the find method takes recId as parameter.

The right method is findbyPosition.

Regards,

M

Was this reply helpful? Yes No