Hi Ray,
Glad you got it working.
If you know when the discount will expire when you create the journal, you can set the end date at this time. If you don't know when it will expire at the time you create the journal, then you will have to leave it open.
When the discount does expire, you can just delete it. Create a new price agreement journal with no lines. On the 'Lines' form, hit the 'Select' button. You use this to bring existing discounts (or prices) into the journal. When you get the discount you want to delete into the journal, use the 'Select all trade agreements for deletion' button. It will mark the line for deletion. When you post the journal, it will be deleted.
If you want to maintain a record that there once was a discount, you will have to create a new discount with an End date, and delete the original one. Steven came up with the solution for this; and I quote it when ever I can:
Use 'Select' to get the discount into the Journal. Use 'Copy and revise', to copy the discount AND add a 'To date'. Post the Journal.
You now have two discounts! One with an end date and one without.
To get rid of the discount without an end date, create a new journal and use 'Select' to bring in both discounts. Select the line with the 'To date' defined, and press Alt + F9 to remove it from the journal.
Press the "Select all trade agreements for deletion" button. Then post the journal.
This will delete the original discount, and leave the discount with an end date. The discount will stop being applied after the end date.