Finance | Project Operations, Human Resources, ...

How to improve performance in x++(Loop, Insert)

(0) Share

Report

Posted on by KS-27040853-0

I am in the process of modifying a class to improve performance.
I am calling a child method for insert in a parent method that is looping, is there room for performance improvement here?
I would like to know in detail how to modify it. Thank you in advance.

※This is a rough image.

private void【parent method】

{

while...

{

　　　　・

this.【child method】

　　　　・

}

==============================

private void【child method】(TableB, strC)

{

TableA.XXX = TableB.XXX;

TableA.YYY = TableB.YYY;

　　　　・

TableA.ZZZ = strC;

TableA.insert();

}

==============================

I have the same question (0)

All responses (3)

Answers (0)

Sort by

Suggested answer

Judy Microsoft Employee on at

Like (0)

Report
Copy link

Link copied!

Hi, instead of calling the child method for each iteration of the loop, you can modify the child method to accept a collection of 'TableB' objects e.g.: List<TableB> List = new List<TableB>(); then perform a batch insert operation.

This can reduce the number of database calls and improve performance.

Hope it can give you some hints.

List<T> Class (System.Collections.Generic) | Microsoft Learn

Was this reply helpful? Yes No
Suggested answer

André Arnaud de Cal... 305,659 Super User 2026 Season 1 on at

Like (0)

Report
Copy link

Link copied!

Hi,

There are two options for making this concept faster. In case you insert records in a loop, the database is called every insert. There can be some latency or table locks, depending on the situation. You can consider using a RecordInsertList or the command insert_recordset for one database call and better performance.

Depending on how strC is calculated, you can use both or only the RecordInsertList.

You can read more here:

RecordInsertList Class (Dynamics.AX.Application) | Microsoft Learn

insert_recordset | Microsoft Learn

In one of my blogs, I also talked about insert_recordset preventing nested loops

Slow or fast? Performance considerations for the while select statement - Dynamicspedia

Was this reply helpful? Yes No
Suggested answer

Mohamed Amine Mahmoudi 26,803 Super User 2026 Season 1 on at

Like (0)

Report
Copy link

Link copied!
Hi,

I suggest to use RecordInsertList

e.g.

RecordInsertList myTableList; MyTable myTable; myTableList = new RecordInsertList(tableNum(<<YourTable>>)); while(<<your condition>>) // Loops { myTable.clear(); myTable.test = 'Test' myTableList.add(myTable); } myTableList.insertDatabase();

Best Regards,

Mohamed Amine MAHMOUDI

Was this reply helpful? Yes No